Connect to rethinkdb with a custom certificate #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also corrected a couple of typo |
| @@ -61,6 +76,28 @@ func (c *RethinkDBConnection) GetSession() *r.Session { | |||
| return c.session | |||
| } | |||
|
|
|||
| // loadCertificate reads a certificate either from a file or from a string | |||
| func loadCertificate() []byte { | |||
There was a problem hiding this comment.
Could you add a test for this? Also, the name suggests that this is a function for loading any certificate, not just the RETHINK_TLS one. For better testing, you could implement this signature instead:
type importRethinkDBRootCA func(opts *gorethink.ConnectOpts)
Additionally, if a root ca is loaded, there should be a warning using logrus.Warnf(), similar to https://github.com/ory-am/hydra/blob/master/cmd/host.go#L98 or https://github.com/ory-am/hydra/blob/master/cmd/host.go#L135
|
Hey this looks already pretty good :) Please remember to sign your commit - read how |
Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
|
perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user to specify a custom certificate to connect to rethinkdb (useful when using services such as compose).
Introduces two new environmental variables:
RETHINK_TLS_CERT_PATHandRETHINK_TLS_CERTFix #114