Adds name and host name to RunWithOptions

ory · Nov 30, 2017 · b7100a8 · b7100a8
1 parent 0c237ab
commit b7100a8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/dockertest.go b/dockertest.go
@@ -119,6 +119,8 @@ func shouldPreferTls(endpoint string) bool {
 
 // RunOptions is used to pass in optional parameters when running a container.
 type RunOptions struct {
+	Hostname     string
+	Name         string
 	Repository   string
 	Tag          string
 	Env          []string
@@ -178,7 +180,9 @@ func (d *Pool) RunWithOptions(opts *RunOptions) (*Resource, error) {
 	}
 
 	c, err := d.Client.CreateContainer(dc.CreateContainerOptions{
+		Name: opts.Name,
 		Config: &dc.Config{
+			Hostname:     opts.Hostname,
 			Image:        fmt.Sprintf("%s:%s", repository, tag),
 			Env:          env,
 			Entrypoint:   ep,

diff --git a/dockertest_test.go b/dockertest_test.go
@@ -72,3 +72,16 @@ func TestMongo(t *testing.T) {
 	require.Nil(t, err)
 	require.Nil(t, pool.Purge(resource))
 }
+
+func TestContainerWithName(t *testing.T) {
+	resource, err := pool.RunWithOptions(
+		&RunOptions{
+			Name: "db",
+			Repository: "postgres",
+			Tag: "9.5",
+		})
+	require.Nil(t, err)
+	assert.Equal(t,"/db", resource.Container.Name)
+
+	require.Nil(t, pool.Purge(resource))
+}