Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports in docs #125

Merged
merged 1 commit into from
May 16, 2018
Merged

Fix imports in docs #125

merged 1 commit into from
May 16, 2018

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented May 13, 2018

According to #123 gopkg.in import should not be used anymore, but it's still mentioned in the project README.

This PR changes imports in the readme to the correct URL.

@aeneasr
Copy link
Member

aeneasr commented May 14, 2018

Hm, could we change go get to dep in order to properly fetch the 0.3.0 branch?

@dennwc
Copy link
Contributor Author

dennwc commented May 14, 2018

@arekkas PTAL. Is this what you had in mind?

@aeneasr
Copy link
Member

aeneasr commented May 16, 2018

Almost!

dep ensure -add github.com/ory/dockertest@v3.x.y

should do the trick!

@dennwc
Copy link
Contributor Author

dennwc commented May 16, 2018

Done

@aeneasr
Copy link
Member

aeneasr commented May 16, 2018

Thank you!

@aeneasr aeneasr merged commit 7b75083 into ory:v3 May 16, 2018
@aeneasr aeneasr mentioned this pull request May 16, 2018
Closed
@dennwc dennwc deleted the fix_import branch July 16, 2018 16:04
xstevens pushed a commit to xstevens/dockertest that referenced this pull request Dec 2, 2019
@dennwc @arekkas
Fixes imports in docs and use dep for pinning specific version (ory#125)
e66db24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dennwc @aeneasr