Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API to remove containers by name #152

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Provide API to remove containers by name #152

merged 2 commits into from
Jan 14, 2019

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Jan 14, 2019

Signed-off-by: Andrea Panattoni panattoni.andrea@gmail.com

Related issue

Resolves #151 as discussed with @aeneasr

Proposed changes

Add API to remove a container by its name. I'm not completely sure about the function name. Feedbacks are welcome.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

NaN

Signed-off-by: Andrea Panattoni <panattoni.andrea@gmail.com>
@aeneasr
Copy link
Member

aeneasr commented Jan 14, 2019

Awesome, thank you! Could we rename RemoveContainerWithName to RemoveContainerByName? :)

@zeeke
Copy link
Contributor Author

zeeke commented Jan 14, 2019

Awesome, thank you! Could we rename RemoveContainerWithName to RemoveContainerByName? :)

Sounds good to me 👍

Signed-off-by: Andrea Panattoni <panattoni.andrea@gmail.com>
@aeneasr
Copy link
Member

aeneasr commented Jan 14, 2019

Thank you!

@aeneasr aeneasr merged commit f76851e into ory:v3 Jan 14, 2019
xstevens pushed a commit to xstevens/dockertest that referenced this pull request Dec 2, 2019
Signed-off-by: Andrea Panattoni <panattoni.andrea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API to remove old containers
2 participants