Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how to to run dockertest in gitlab ci #229

Merged
merged 2 commits into from Oct 13, 2020
Merged

docs: how to to run dockertest in gitlab ci #229

merged 2 commits into from Oct 13, 2020

Conversation

glossd
Copy link
Contributor

@glossd glossd commented Oct 9, 2020

Related issue

#191

Proposed changes

Just adding readme for gitlab ci users.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@glossd glossd changed the title Add readme on how to to run dockertest in gitlab ci docs: how to to run dockertest in gitlab ci Oct 9, 2020
aeneasr
aeneasr requested changes Oct 11, 2020
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution! This looks pretty good but I have some ideas how to improve it further :)

docs/GitlabCI.md Outdated
@@ -0,0 +1,47 @@
# Running dockertest in Gitlab CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would work well in the README! Would you be open to copy the contents there? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done)

@glossd glossd requested a review from aeneasr October 12, 2020 21:19
aeneasr
aeneasr approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit 0c817b3 into ory:v3 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glossd @CLAassistant @aeneasr