Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add error handling after container purging #231

Merged
merged 1 commit into from Oct 18, 2020

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Oct 16, 2020

Related issue

none.
As this has just minor changes, I created this PR without prior discussion.

Proposed changes

Adds error handling after pool.Purge in example codes README.md is already doing.
It may be trivial, but I think it's worth adding so that users don't forget to add this handling when they are creating their own codes with referring these examples.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020

CLA assistant check
All committers have signed the CLA.

@sryoya sryoya changed the title example: Add error handling after pool.Purge() docs: Add error handling after container purging Oct 16, 2020
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit 36806f7 into ory:v3 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants