Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #205 add volume support #273

Closed
wants to merge 3 commits into from
Closed

fix: #205 add volume support #273

wants to merge 3 commits into from

Conversation

mvid
Copy link

@mvid mvid commented Jun 11, 2021

Related issue

#205 volume support

Proposed changes

The changes i made makes creating volumes in RunOptions possible.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

This is based on the closed PR #206 by @JulianGlowania, addressing the comments on it before it was marked inactive.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2021

CLA assistant check
All committers have signed the CLA.

@mvid mvid changed the title fix ory#205 add volume support fix: #205 add volume support Jun 11, 2021
@aeneasr
Copy link
Member

aeneasr commented Jun 18, 2021

Thank you! We merged a fix for volume mount on windows, see #247 - could you take a look and incorporate the change in your PR?

Also sorry for the late reply, somehow this missed my inbox.

@mvid
Copy link
Author

mvid commented Jun 18, 2021

@aeneasr I am a bit confused, I don't see anything related to volumes or windows in #247

@aeneasr
Copy link
Member

aeneasr commented Jun 20, 2021

Sorry I meant #274

@aeneasr
Copy link
Member

aeneasr commented Jul 14, 2021

Closing this as per comment #273 (comment)

@aeneasr aeneasr closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants