Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove direct dependency on gotest.tools/v3 #504

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jun 13, 2024

Related Issue or Design Document

The PR replaces usages of gotest.tools/v3 with github.com/stretchr/testify because the latter is mainly used in the repo tests.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This refactoring removes gotest.tools/v3 from direct dependencies, which can be seen in the go.mod.

@alnr alnr merged commit 84015fd into ory:v3 Jun 13, 2024
6 checks passed
@alexandear alexandear deleted the chore-remove-gotest-tools branch June 14, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants