Possibility to pass the command that will be executed on the container #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Rodrigues Junior <robertogyn19@gmail.com>
|
Hey, thanks, this looks solid! |
aeneasr
reviewed
Mar 25, 2017
dockertest.go
Outdated
| Env: env, | ||
| } | ||
|
|
||
| return d.RunWithOptions(opts) |
There was a problem hiding this comment.
This could probably be a one liner:
return d.RunWithOptions(RunOptions{})
aeneasr
reviewed
Mar 25, 2017
dockertest_test.go
Outdated
| assert.NotEmpty(t, port) | ||
|
|
||
| err = pool.Retry(func() error { | ||
| _, err := http.Get(fmt.Sprintf("http://127.0.0.1:%s", port)) |
There was a problem hiding this comment.
Also check for status code here, just to be sure?
Signed-off-by: Roberto Rodrigues Junior <robertogyn19@gmail.com>
|
Thanks for the comments, I've already made the suggested changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scenario is useful in cases where you need to pass some parameter that is not via environment variable.