Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: crypt import #1426

Merged
merged 3 commits into from
Jun 9, 2023
Merged

docs: crypt import #1426

merged 3 commits into from
Jun 9, 2023

Conversation

indietyp
Copy link
Contributor

@indietyp indietyp commented Jun 5, 2023

Document the addition of crypt(3) functions, how they are used and the supported format.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jun 5, 2023
@hperl hperl self-requested a review June 7, 2023 08:25
hperl
hperl requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just finalize the tags and keep them synced with the implementation.

docs/kratos/manage-identities/25_import-user-accounts-identities.mdx Outdated Show resolved Hide resolved
docs/kratos/manage-identities/25_import-user-accounts-identities.mdx Outdated Show resolved Hide resolved
docs/kratos/manage-identities/25_import-user-accounts-identities.mdx Outdated Show resolved Hide resolved
indietyp and others added 2 commits June 7, 2023 12:07
hperl
hperl approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM! 🎉

@aeneasr aeneasr merged commit f0b61f0 into ory:master Jun 9, 2023
7 checks passed
@hperl hperl mentioned this pull request Jun 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hperl hperl hperl approved these changes

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees

@hperl hperl

Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@indietyp @hperl @aeneasr @vinckr