Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefix the css class names #163

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: prefix the css class names #163

merged 3 commits into from
Oct 17, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Oct 16, 2023

This PR simplifies class overrides by providing a prefix name for the generated CSS classes.

In this case we add a prefix ory_elements__ to each class name.

The format is as follows: ory_elements___<variant|size>__hash

Example generated classes:
ory_elements__button_social__i8n2ik0
ory_elements__button_social_size_medium__ecxsa2d
ory_elements__button_social_variant_semibold__xas31dg

See this discussion for more details
#162

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko
Copy link
Contributor Author

Without the hash doesn't work.
image

even playwright tests are failing since the UI elements aren't rendering properly. I'll add the hash back.

@Benehiko Benehiko merged commit 11a97ff into main Oct 17, 2023
13 checks passed
@Benehiko Benehiko deleted the feat-prefix-css-naming branch October 17, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants