feat: kratos nextjs with tailwindcss example #55
Conversation
|
vijesh deepan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
this is an example for kratos nextjs with tailwind css |
gopher1990
changed the title
gopher1990
changed the title
| - id: github | ||
| provider: github | ||
| client_id: ... # Add the client ID | ||
| client_secret: ... # Add the client secret |
There was a problem hiding this comment.
You need to provide Client_secret that you got from google
| providers: | ||
| - id: github | ||
| provider: github | ||
| client_id: ... # Add the client ID |
| essential: true | ||
| family_name: null | ||
| hd: null # If you want the G Suite domain | ||
| password: |
There was a problem hiding this comment.
Why did you place password method here ?This should be on line 36
There was a problem hiding this comment.
I agree would be better to have the password method first and then social
There was a problem hiding this comment.
Thanks a lot for the contribution @gopher1990
I tried out the example and login/signup and recovery worked, awesome.
I have some ideas on how to improve the example:
- use @ory/client instead of @ory/kratos-client (both work but the former will be the main SDK going forward
- use https://playground.projects.oryapis.com/ as default kratos with optional instructions to run it using docker-compose
- this would be nice to have, but some tests, like we have for the django example
Let me know if I can help with that!
| @@ -0,0 +1,12 @@ | |||
|
|
|||
| # add the client id and client secret for google,github in kratos.yml file inside the config folder | |||
There was a problem hiding this comment.
Can you please use the README template from here:
https://raw.githubusercontent.com/ory/examples/master/_common/README.md
having an uniform README for all examples will help navigate the different examples :)
| essential: true | ||
| family_name: null | ||
| hd: null # If you want the G Suite domain | ||
| password: |
There was a problem hiding this comment.
I agree would be better to have the password method first and then social
|
Hey @gopher1990 |
|
Sure
…On Mon, 10 Oct, 2022, 3:19 pm Vincent, ***@***.***> wrote:
Hey @gopher1990 <https://github.com/gopher1990>
are you up to change the README to the template
<https://raw.githubusercontent.com/ory/examples/master/_common/README.md>
we use in this repo and address the comments on your PR?
It wont be much and then we can merge it 🤞 (we can add tests later on)
—
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZUTU6PQ55TPMBBJSAH3XYTWCPRCJANCNFSM6AAAAAAQQG6EEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello @gopher1990 |
|
|
||
|
|
||
| const LoginPage = ({ flowData }: { flowData: SelfServiceLoginFlow }) => { | ||
| console.log(flowData); |
There was a problem hiding this comment.
did you mean to leave this console log here?
| import Link from "next/link"; | ||
|
|
||
| const RecoveryPage = ({ flowData }: { flowData: SelfServiceRecoveryFlow }) => { | ||
| console.log(flowData); |
| setLastName(flowData.identity.traits.name.last); | ||
| }, [flowData]); | ||
|
|
||
| console.log("flowData", flowData); |
Related Issue or Design Document
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments