Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hydra 2.0 integration example #67

Closed
wants to merge 4 commits into from

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Feb 13, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr changed the title feat: Hydra 2.0 integration example feat: hydra 2.0 integration example Feb 13, 2023
* feat: hydra & kratos integration example

* * fix: removed files from kratos-hydra that were incorrectly copied

* style: code updates on kratos-hydra from running "make format"
@vinckr vinckr mentioned this pull request Feb 21, 2023
6 tasks
@aldy505
Copy link

aldy505 commented Mar 1, 2023

Hi, what's keeping this PR as a draft? Is there any other remaining works to do?

@vinckr
Copy link
Member Author

vinckr commented Mar 1, 2023

Hello @aldy505
Yes, the example is not yet functional.
Any help with it appreciated 🙇

@aldy505
Copy link

aldy505 commented Mar 1, 2023

Can you please put some more details on parts which are not functional yet?

@vinckr
Copy link
Member Author

vinckr commented Mar 1, 2023

AFAICT the consent screen is not working as intended and redirecting correctly.
But best pull the branch and test it out yourself.

@Jorgagu Jorgagu mentioned this pull request May 2, 2023
6 tasks
* chore(add-idea-gitignore):  add .idea folder to gitignore file (#69)

* fix: README draft

* feat: hydra & kratos integration example (#2976) (#68)

* feat: hydra & kratos integration example

* * fix: removed files from kratos-hydra that were incorrectly copied

* style: code updates on kratos-hydra from running "make format"

* fix: consent page not working

---------

Co-authored-by: Matt Barnicle <mattbarnicle@users.noreply.github.com>
Co-authored-by: Vincent <vincent@ory.sh>
@vinckr vinckr marked this pull request as ready for review May 5, 2023 07:20
@Jorgagu Jorgagu mentioned this pull request May 16, 2023
6 tasks
@vinckr
Copy link
Member Author

vinckr commented Jun 5, 2023

added in #71

@vinckr vinckr closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants