Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State parameter length issue when working with spring security oauth2 #267

Closed
pragkent opened this issue May 16, 2018 · 4 comments · Fixed by #461
Closed

State parameter length issue when working with spring security oauth2 #267

pragkent opened this issue May 16, 2018 · 4 comments · Fixed by #461

Comments

@pragkent
Copy link

The default state generator of spring security oauth2 library generates state with length of 6 which is less than the MinParameterEntropy(which is 8). check code here

I wonder that if it's possible to adjust MinParameterEntropy? or make it configurable?

@aeneasr
Copy link
Member

aeneasr commented May 16, 2018

Making it configurable would be an option

@pragkent
Copy link
Author

Any thought of how to implement it?
My first thought was making MinParameterEntropy a variable instead of a const.

@aeneasr
Copy link
Member

aeneasr commented May 25, 2018

Yeah, just add a Fosite.GetMinParameterEntropy() function which returns either MinParameterEntropy, or - if set - the value of e.g. Fosite.MinParameterEntropy which can be set when initializing the struct.

@mitar
Copy link
Contributor

mitar commented Aug 13, 2020

I made #461 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants