Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix broken dependencie to reflection package. #555

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

titouanfreville
Copy link
Contributor

@titouanfreville titouanfreville commented Jan 9, 2021

oleiade overwrotte version 1.0 of reflection module while updating
witch caused securtiy error to be triggered on fresh environement.

Updated fosite version requirements to 1.0.1 witch is a fixed version
for module.

Also add to add a replace to enforce reflection package version on
fosite 0.29 witch is still used by ory/x.
Replacement can be removed once X is up to date.

Related to issue: #553

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2021

CLA assistant check
All committers have signed the CLA.

oleiade overwrotte version 1.0 of reflection module while updating
witch caused securtiy error to be triggered on fresh environement.

Updated fosite version requirements to 1.0.1 witch is a fixed version
for module.

Also add to add a replace to enforce reflection package version on
fosite 0.29 witch is still used by ory/x.
Replacement can be removed once X is up to date.
@aeneasr aeneasr merged commit a103222 into ory:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants