Regression fix for request ID in refresh token flow #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Beorn Facchini <beorn@lade.io>
|
Nice catch, thanks! |
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
Signed-off-by: Beorn Facchini <beorn@lade.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanitize request method introduced a change where the generated ID for an access token and refresh token are different for the same response.
This is due to the ID being generated on the sanitized request not being passed back to the handler e.g. https://github.com/ory/fosite/blob/master/handler/oauth2/flow_refresh.go#L110.
To mitigate this the request ID is pre-generated on the original requester. There may be a better approach that would also pass the test.