fix: Do not include nonce in ID tokens when not used #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Mar 15, 2021
|
Fixed tests. |
aeneasr
requested changes
Apr 14, 2021
|
Are you still up for the changes? :) If you need any help, let us know! |
|
Converting to draft due to lack of response |
|
Addressed comments. |
|
I think CI is failing because of invalid configuration, not because of something I would have introduced in this PR. |
|
Possible, I restarted the CI! |
5 tasks
|
Right, we had this issue in another PR. I create a PR in Ory Hydra which bumps the fosite dep to your fork. If the CI passes there, then the one here would also pass! |
|
It seems it passed. Could this be fixed in CI somehow? It is pretty ugly that (contributing to) this repository now depends in this way on Hydra's one? |
done! |
|
😎 |
mattmoyer
added a commit
to mattmoyer/pinniped
that referenced
this pull request
May 28, 2021
The new version has different behavior for the `nonce` claim, which is now omitted if it would be empty (see ory/fosite#570). Signed-off-by: Matt Moyer <moyerm@vmware.com>
mattmoyer
added a commit
to mattmoyer/pinniped
that referenced
this pull request
May 28, 2021
The new version has different behavior for the `nonce` claim, which is now omitted if it would be empty (see ory/fosite#570). Signed-off-by: Matt Moyer <moyerm@vmware.com>
mattmoyer
added a commit
to mattmoyer/pinniped
that referenced
this pull request
May 28, 2021
The new version has different behavior for the `nonce` claim, which is now omitted if it would be empty (see ory/fosite#570). Signed-off-by: Matt Moyer <moyerm@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Not sure why was this there, but it makes no sense and there is no point in making ID tokens larger just to include an empty string.
Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).