Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize name of secret #125

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

TartanLeGrand
Copy link
Contributor

Proposed changes

This pull request introduces the ability to customize ClientIDKey and ClientSecretKey variables. These variables can now be modified by setting the environment variables CLIENT_ID_KEY and CLIENT_SECRET_KEY respectively. If these environment variables are not set, the default values (currently "CLIENT_ID" for ClientIDKey and "CLIENT_SECRET" for ClientSecretKey) will be used.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

In this pull request, I have modified ClientIDKey and ClientSecretKey to be configurable via environment variables. This allows for greater flexibility in configuring the system, while maintaining sensible defaults.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023

CLA assistant check
All committers have signed the CLA.

@TartanLeGrand
Copy link
Contributor Author

@Demonsthere can you review this ? 😃


DefaultNamespace = "default"
)

var (
ClientIDKey = DefaultClientID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is pretty simple and I see no reason to why not merge it, but need one little thing first ;) As we're adding new config options, with Envs, please update the README accordingly!

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme then we can merge 😉

@Demonsthere Demonsthere merged commit 35abbe3 into ory:master Oct 24, 2023
7 checks passed
@afreakk
Copy link

afreakk commented Mar 5, 2024

Hmm, here the default values went from lowercase to uppercase....
So it kinda broke existing crds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants