fix(resolver): Fix client name detection for updates #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Feb 4, 2020
| @@ -160,7 +160,7 @@ func (r *OAuth2ClientReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error | |||
| } | |||
|
|
|||
| if found { | |||
| if fetched.Owner != oauth2client.Name { | |||
| if fetched.Owner != fmt.Sprintf("%s/%s", oauth2client.Name, oauth2client.Namespace) { | |||
There was a problem hiding this comment.
Shouldn't this be namespace/name?
There was a problem hiding this comment.
when I list the clients with the hydra REST API it's orderd name/namespace. Using hydra 1.2.2
There was a problem hiding this comment.
Right, appears to come from here:
paulbdavis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the maester creates a client, it adds the namespace to the owner. This fix takes that into account when checking for updates.
Without this patch, the maester fails to update the client with hydra when the k8s admin makes changes to the oauth2client resource in a namespace.
Testing image is available at
dangersalad/hydra-maester:v0.0.12-alpha2