oauth2: resolve session issue with deep nested session

Closes #512
ory · Jun 17, 2017 · a89a470 · a89a470
1 parent 0f98e88
commit a89a470
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/glide.lock b/glide.lock
diff --git a/glide.yaml b/glide.yaml
@@ -64,6 +64,7 @@ import:
   subpackages:
   - clientcredentials
 - package: gopkg.in/yaml.v2
+- package: github.com/mohae/deepcopy
 testImport:
 - package: github.com/bmizerany/assert
 - package: github.com/ory/dockertest
diff --git a/oauth2/session.go b/oauth2/session.go
@@ -1,9 +1,7 @@
 package oauth2
 
 import (
-	"bytes"
-	"encoding/gob"
-
+	"github.com/mohae/deepcopy"
 	"github.com/ory/fosite"
 	"github.com/ory/fosite/handler/openid"
 	"github.com/ory/fosite/token/jwt"
@@ -29,11 +27,5 @@ func (s *Session) Clone() fosite.Session {
 		return nil
 	}
 
-	var clone Session
-	var mod bytes.Buffer
-	enc := gob.NewEncoder(&mod)
-	dec := gob.NewDecoder(&mod)
-	_ = enc.Encode(s)
-	_ = dec.Decode(&clone)
-	return &clone
+	return deepcopy.Copy(s).(fosite.Session)
 }