Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message for migrate sql is unclear regarding source of database URL. #1411

Closed
dkushner opened this issue May 1, 2019 · 1 comment
Closed

Comments

@dkushner
Copy link
Contributor

dkushner commented May 1, 2019

Describe the bug
When invoking the hydra sql migrate command, the help message indicates that the database URL must either be specified as a command line argument (i.e. hydra sql migrate <DATABASE_URL>) or sourced from the environment variable DSN if the user specifies the -e flag.

In reality, if the user specifies the -e flag, it will also (only?) pull the database URL from the config file provided via the --config flag.

To Reproduce
Steps to reproduce the behavior:

  1. Run hydra sql migrate --config test.yaml where the test configuration file specifies a database URL under the dsn key.
  2. Observe that the command is not executed and instead a usage message is output in the terminal.

Expected behavior
The command would read the target database URL from the indicated config file.

Version:

  • Environment: Kubernetes
  • Version v1.0.0-rc10
@aeneasr
Copy link
Member

aeneasr commented May 2, 2019

This is now resolved as discussed per discord and #1412

@aeneasr aeneasr closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants