Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status code 401 instead of 404 for clients not found in GET /clients/{id} #1744

Closed
antogyn opened this issue Mar 2, 2020 · 2 comments
Closed

Comments

@antogyn
Copy link

antogyn commented Mar 2, 2020

Describe the bug

I updated hydra from 1.0.0 to 1.3.2 so I'm not sure when this bug was introduced, now calling /clients/{id} on the admin api with a non existing client id returns a 401 instead of a 404.

Reproducing the bug

Steps to reproduce the behavior:

# default configuration (admin port = 4445)
curl http://127.0.0.1:4445/clients/thisdoesnotexist

result:

{
  "error": "The request could not be authorized",
  "error_description": "The requested OAuth 2.0 client does not exist or you did not provide the necessary credentials",
  "status_code": 401,
  "request_id": ""
}
@antogyn
Copy link
Author

antogyn commented Mar 2, 2020

Just realized this is a feature #1617

I think the documentation should be updated to remove 404 from possible errors

@antogyn antogyn closed this as completed Mar 2, 2020
@aeneasr
Copy link
Member

aeneasr commented Mar 2, 2020

Correct, that should be indeed removed!

aeneasr added a commit that referenced this issue Mar 2, 2020
aeneasr added a commit that referenced this issue Mar 3, 2020
eli-zh pushed a commit to eli-zh/hydra that referenced this issue Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants