Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQA_OPT_OUT env var ignored #2358

Closed
pjediny opened this issue Feb 15, 2021 · 2 comments · Fixed by #2360
Closed

SQA_OPT_OUT env var ignored #2358

pjediny opened this issue Feb 15, 2021 · 2 comments · Fixed by #2360
Labels
bug Something is not working. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@pjediny
Copy link
Contributor

pjediny commented Feb 15, 2021

Describe the bug
https://www.ory.sh/docs/ecosystem/sqa/ describes how to disable SQA, but the hydra is ignoring the setting via env var.

Reproducing the bug
Run with env var set SQA_OPT_OUT=true
There is no sqa configuration in config file
There is no sqa configuration as command line flag

Check logs for message:

level=info msg=Software quality assurance features are enabled. Learn more at: https://www.ory.sh/docs/ecosystem/sqa audience=application service_name=ORY Hydra service_version=v1.9.2

Expected behavior
Expecting SQA_OPT_OUT=true to disable telemetry

Environment

  • Version: v1.9.2
  • Environment: k8s

** Notes **

Command line flag --sqa-opt-out has effect
Probably caused by change from viper to koanf
@aeneasr
Copy link
Member

aeneasr commented Feb 15, 2021

Ah yes, thank you for finding this - that's most likely a regression from the recent move to koanf. If you can, could you provide a PR? Highly appreciate your help!

@aeneasr aeneasr added bug Something is not working. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Feb 15, 2021
pjediny added a commit to pjediny/hydra that referenced this issue Feb 16, 2021
@pjediny
fix: adds sqa section to config.schema.json
17cde53 
Move from viper to koanf caused env vars without corresponding
paths in config.schema.json to be ignored. This commit adds
missing sqa section, so the SQA_OPT_OUT env var has effect again.

Closes: ory#2358
@pjediny pjediny mentioned this issue Feb 16, 2021
Merged
5 tasks
@pjediny
Copy link
Contributor Author

pjediny commented Feb 16, 2021

Done.

But I could not go test ./... as it fails on downloading dependency:

go test ./...
go: github.com/ory/cli@v0.0.35 requires
        github.com/gobuffalo/fizz@v1.13.1-0.20200903094245-046abeb7de46: invalid version: unknown revision 046abeb7de46

Tested only by make docker and running the image with docker run.

aeneasr pushed a commit that referenced this issue Feb 16, 2021
@pjediny
fix: adds sqa section to config.schema.json (#2360)
89df8d7 
Move from viper to koanf caused env vars without corresponding
paths in config.schema.json to be ignored. This commit adds
missing sqa section, so the SQA_OPT_OUT env var has effect again.

Closes: #2358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adds sqa section to config.schema.json pjediny/hydra
2 participants
@aeneasr @pjediny