Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for hydra-clients-import is incorrect #2732

Closed
grega opened this issue Sep 9, 2021 · 2 comments
Closed

Documentation for hydra-clients-import is incorrect #2732

grega opened this issue Sep 9, 2021 · 2 comments
Labels
good first issue A good issue to tackle when being a novice to the project.
Milestone

Comments

@grega
Copy link

grega commented Sep 9, 2021

The docs at https://www.ory.sh/hydra/docs/cli/hydra-clients-import state as a description:

"Imports cryptographic keys of any format to the JSON Web Key Store

This appears to be incorrect. The description would be expected to be:

"Import OAuth 2.0 Clients from one or more JSON files"

(and this is confirmed by an earlier version of the docs for this CLI interface: https://www.ory.sh/hydra/docs/v1.9/cli/hydra-clients-import/)

This commit specifically seems to introduce the issue (where hydra-keys-import is confused with hydra-clients-import): 7731121

@aeneasr
Copy link
Member

aeneasr commented Sep 12, 2021

Oh yeah that appears to be a copy/paste error! Would you be up for a fix? :)

@aeneasr aeneasr added docs good first issue A good issue to tackle when being a novice to the project. labels Sep 14, 2021
@aeneasr aeneasr added this to the v1.11 milestone Sep 14, 2021
masoudtahmasebi93 added a commit to masoudtahmasebi93/hydra that referenced this issue Sep 30, 2021
masoudtahmasebi93 added a commit to masoudtahmasebi93/hydra that referenced this issue Sep 30, 2021
@masoudtahmasebi93
Copy link
Contributor

Since it was just documentation, Based on the comment from the issue opener I tried to make it correct, if there is anything that needs correction I would be happy to make changes.

@aeneasr aeneasr closed this as completed in ea7a20c Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue to tackle when being a novice to the project.
Projects
None yet
Development

No branches or pull requests

3 participants