Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing data in JWT grant #3143

Merged
merged 3 commits into from
Jun 14, 2022
Merged

fix: missing data in JWT grant #3143

merged 3 commits into from
Jun 14, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 9, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security.
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr changed the base branch from master to servicelocator June 9, 2022 10:57
@aeneasr aeneasr changed the title Jwt grant data fix: missing data in JWT grant Jun 9, 2022
@aeneasr aeneasr marked this pull request as ready for review June 9, 2022 10:57
Base automatically changed from servicelocator to v2.x June 14, 2022 07:05
akrause-cel and others added 3 commits June 14, 2022 09:07
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v2.x@6644e8b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 681e143 differs from pull request most recent head 3637579. Consider uploading reports for the commit 3637579 to get more accurate results

@@           Coverage Diff           @@
##             v2.x    #3143   +/-   ##
=======================================
  Coverage        ?   79.11%           
=======================================
  Files           ?      114           
  Lines           ?     8486           
  Branches        ?        0           
=======================================
  Hits            ?     6714           
  Misses          ?     1382           
  Partials        ?      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6644e8b...3637579. Read the comment docs.

@aeneasr aeneasr merged commit f6881c3 into v2.x Jun 14, 2022
@aeneasr aeneasr deleted the jwt-grant-data branch June 14, 2022 07:46
aeneasr added a commit that referenced this pull request Jun 27, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
grantzvolsky pushed a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
aeneasr added a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
aeneasr added a commit that referenced this pull request Aug 18, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
aeneasr added a commit that referenced this pull request Sep 5, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
aeneasr added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Andreas Krause <a.krause@celonis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants