Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document error redirect to identity provider #96

Closed
janekolszak opened this issue Jun 5, 2016 · 2 comments
Closed

Document error redirect to identity provider #96

janekolszak opened this issue Jun 5, 2016 · 2 comments
Assignees
Milestone

Comments

@janekolszak
Copy link

Hi,
I think I found a small bug in consent handling by Hydra when integrating with a IdP.

When I run hydra token user --skip-tls-verify I get a URL.
The first time I visit it's OK and I get:

Access Token: 8e3ncb7eCmGKkCqfgPG5aG6an2a99PBU8yS0n1Y8N10.hvtTEnQ77MZyw37wv-A06Rz4XgImhdxxllCZTQLiRG0
Refresh Token: CeVd5hfnWppHP8xQScCFZjuqd5FROXG7SqIghUYxxVU.uRSryI0bCDmTx6WWBuhmYr0fXrziidNhlTAv6q8zGVM
Expires in: 2016-06-05 23:28:17.617825487 +0200 CEST

The second time I visit I get an error and that's ok.

However the IdP gets called anyway and this is probably bad.

@aeneasr
Copy link
Member

aeneasr commented Jun 5, 2016

if an error occurs, the idp url should contain a uri query param called error (https://login.myapp.com/login?error=.... the error should be taken by the idp and displayed :)

this happens when, according to spec, hydra is not allowed to redirect back to the client callback when an error occurs.

let me know if the error param is not available and reopen this issue.

@aeneasr aeneasr closed this as completed Jun 5, 2016
@aeneasr
Copy link
Member

aeneasr commented Jun 5, 2016

However, this should be documented

@aeneasr aeneasr reopened this Jun 5, 2016
@aeneasr aeneasr changed the title Hydra Document idp error redirect Jun 5, 2016
@aeneasr aeneasr changed the title Document idp error redirect Document error redirect to identity provider Jun 5, 2016
@aeneasr aeneasr added this to the 0.2.0 milestone Jul 24, 2016
@aeneasr aeneasr self-assigned this Jul 24, 2016
aeneasr pushed a commit that referenced this issue Jul 25, 2016
@aeneasr aeneasr closed this as completed Jul 25, 2016
aeneasr pushed a commit that referenced this issue Aug 9, 2016
* warden: rename `assertion` to `token` - closes #158
* config: do not log database credentials - closes #147
* oauth2: upgrade fosite - close #160
* config: do not store database config in hydra config - closes #164
* oauth2: id_token at_hash / c_hash is null - closes #129
* jwk: improve error message of wrong system secrect - closes #104
* readme: improve images, add benchmarks - closes #161
* cmd: improve connect dialogue - closes #170
* cmd: fix --dry option - closes #157
* firewall: document warden interface sdk
* readme: link openid connect and oauth2 introduction
* cmd: introduce FORCE_ROOT_CLIENT_CREDENTIALS env var - closes #140
* readme: document error redirect to identity provider - closes #96
* internal: fosite store must be consistent to avoid errors - closes #176
* client: add GetConcreteClient to http manager
* cmd: host process now logs basic information on all http requests - closes #178
* all: add memory profiling - closes #179
* warden: resolve nil pointer issue - closes #181
* cmd: clean up env to struct mapping, add more controls
* cmd: bcrypt cost should be configurable - closes #184
* cmd: token lifespans should be configurable - closes #183
* cmd: resolve issues with envirnoment config - closes #182
* cmd: implement tls termination capability - closes #177
* cmd: resolve issues with redirect logic and TLS
* oauth2: implement default oauth2 consent endpoint - closes #185
* warden - closes #188 
* oauth2: id token claims should be set by using id_token - closes #188
* oauth2: oauth2 implicit flow should allow custom protocols - closes #180
* oauth2: core scope should not be mandatory - closes #189
* warden: warden sdk should not make distinction between token and request - closes #190
* warden: rename authorized / allowed endpoints to something more meaningful - closes #162
* ci: improve travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants