Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: rename grant type authorize_code to authorization_code #1191

Merged
merged 1 commit into from Nov 29, 2018
Merged

client: rename grant type authorize_code to authorization_code #1191

merged 1 commit into from Nov 29, 2018

Conversation

sjkaliski
Copy link
Contributor

@sjkaliski sjkaliski commented Nov 26, 2018

Signed-off-by: Steve Kaliski sjkaliski@gmail.com

Related issue

ory/docs#78, cc @aeneasr

Proposed changes

The grant_type pattern is incorrect, replaces authorize_code with authorization_code.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Signed-off-by: Steve Kaliski <sjkaliski@gmail.com>
aaslamin pushed a commit to aaslamin/hydra that referenced this pull request Nov 26, 2018
Closes ory#1191

Signed-off-by: aeneasr <aeneas@ory.sh>
@aeneasr
Copy link
Member

aeneasr commented Nov 29, 2018

ty!

@aeneasr aeneasr merged commit 4b97a0f into ory:master Nov 29, 2018
@sjkaliski sjkaliski deleted the client-grant-type-pattern branch November 29, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants