Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token flush CLI description #1251

Merged
merged 1 commit into from Jan 2, 2019

Conversation

sawadashota
Copy link
Contributor

Related issue

none

Proposed changes

"1d" is unavailable unit so that I fixed token flush CLI description.
Only we can use these units: "ns", "us" (or "µs"), "ms", "s", "m", "h".
https://godoc.org/time#ParseDuration

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

"1d" is unavailable unit
https://godoc.org/time#ParseDuration

Signed-off-by: Shota SAWADA <xiootas@gmail.com>
@sawadashota sawadashota force-pushed the fix-token-flush-cli-description branch from 0bbac84 to 8faa74a Compare December 28, 2018 04:22
@aeneasr
Copy link
Member

aeneasr commented Jan 2, 2019

Thank you!

@aeneasr aeneasr merged commit 149573a into ory:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants