consent: Do not confirmLoginSession when skip is true (#1414) #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a regression issue introduced by OpenID Connect Front/Back-Channel Logout. Closes #1409 Signed-off-by: Saad Tazi <stazi@fruitsoftware.com>
This adds tests for making sure that future releases don't regress on the session logic. Signed-off-by: aeneasr <aeneas@ory.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a regression issue introduced by OpenID Connect Front/Back-Channel Logout.
Closes #1409
Signed-off-by: Saad Tazi stazi@fruitsoftware.com
Related issue
Proposed changes
Checklist
vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>. Please be very careful when usingforce push.
Further comments