handler: use generate secrets function as used in cmd #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me secret length like in cmd
If a client is being created by the api and the client_secret is not specified then the client_secret is being generated as a random string of length 26. Co-authored-by: Marco Hutzsch <marco.hutzsch@otto.de>
|
|
|
Thank you! |
|
The handlers have very low test coverage because all of their dependent code is being tested somewhere else. We have some minimal tests here, but they're more or less just checking if something super unexpected happens: https://github.com/ory/hydra/blob/master/cmd/root_test.go |
aeneasr
pushed a commit
that referenced
this pull request
Jan 7, 2020
If a client is being created by the api and the client_secret is not specified then the client_secret is being generated as a random string of length 26.
eli-zh
pushed a commit
to eli-zh/hydra
that referenced
this pull request
Mar 22, 2020
If a client is being created by the api and the client_secret is not specified then the client_secret is being generated as a random string of length 26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a client is created the client secret generation should be the same for api and cli
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
While trying to test the admin interface we recognized there are no tests for the handler. With the client_create.js admin cypress test this done. Did we miss a better part to test the admin handler?