oauth2: add www-authenticate header in case of unauthorized error for userinfo endpoint #1891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Here is the issue that this PR is trying to fix
/userinfo endpoint misses www-authenticate header for 401 response
#1827Proposed changes
As far as I understood, apparently there are two cases that
/userinfo
API returns 401 error. One is if introspection API returns 401 and the other one is if token type is notfosite.AccessToken
. Thus, I covered these two cases by addingwww-authenticate
header with reason coming fromRFC6749Error
I've also added a new test case but needed small changes to make it happen.
This is my first PR, and I'm not familiar with the codebase. I'd be glad to hear better ways to do these changes if any.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments