Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logout error hint #1949

Merged
merged 2 commits into from
Jul 14, 2020
Merged

fix: logout error hint #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9acc50
fix: send correct error_hint during failed logout
phi2039 Jul 12, 2020
9d1407a
fix: send correct error_hint during failed logout
phi2039 Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion consent/strategy_default.go
View file
Open in desktop
Expand Up @@ -738,7 +738,7 @@ func (s *DefaultStrategy) issueLogoutVerifier(w http.ResponseWriter, r *http.Req

if len(state) > 0 {
// state can only be set if it's an RP-initiated logout flow. If not, we should throw an error.
return nil, errors.WithStack(fosite.ErrInvalidRequest.WithHint("Logout failed because query parameter post_logout_redirect_uri is set but id_token_hint is missing"))
return nil, errors.WithStack(fosite.ErrInvalidRequest.WithHint("Logout failed because query parameter state is set but id_token_hint is missing"))
}

if len(requestedRedir) > 0 {
Expand Down
2 changes: 1 addition & 1 deletion consent/strategy_default_test.go
View file
Open in desktop
Expand Up @@ -253,7 +253,7 @@ func TestStrategyLogout(t *testing.T) {
d: "should fail if non-rp initiated logout is initiated with state (indicating rp-flow)",
params: url.Values{"state": {"foobar"}},
lph: noopHandler,
expectBody: `{"error":"invalid_request","error_description":"The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed","error_hint":"Logout failed because query parameter post_logout_redirect_uri is set but id_token_hint is missing","status_code":400,"request_id":""}`,
expectBody: `{"error":"invalid_request","error_description":"The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed","error_hint":"Logout failed because query parameter state is set but id_token_hint is missing","status_code":400,"request_id":""}`,
expectStatusCode: http.StatusBadRequest,
},
{
Expand Down