Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: quickstart config #2328

Merged
merged 7 commits into from
Feb 5, 2021
Merged

docs: quickstart config #2328

merged 7 commits into from
Feb 5, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jan 27, 2021

Added the qu ickstart config to the doc, short explanation where to find the config and how its loaded into docker.
also a few comments in the yaml itself.

It did not fit quite into the quickstart, so I just added it to the bottom.

Let me know what should be changed or further improved, if needed.

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@vinckr vinckr changed the title docs:quickstart config docs: quickstart config Jan 27, 2021
docs/docs/5min-tutorial.mdx Outdated Show resolved Hide resolved
@vinckr
Copy link
Member Author

vinckr commented Jan 29, 2021

Regarding the import of files from GH, do you mean the CodeTabs?
I couldnt find the module in Hydra, but it seems a bit overkill for this case.
Let me know if I should implement it still or if you dont meant CodeTabs at all.

@aeneasr
Copy link
Member

aeneasr commented Feb 1, 2021

Use CodeFromRemote: https://github.com/ory/kratos/blob/master/docs/src/theme/CodeFromRemote.js

All docs are the same thing, if it exists in kratos, it exists here. CodeFromRemote is even used here: https://github.com/ory/hydra/blob/b6f49cd007ee700c2c08c19c875ad734e0822dbf/docs/docs/guides/consent.mdx

@vinckr
Copy link
Member Author

vinckr commented Feb 1, 2021

Ok, much nicer with CodeFromRemote.
I added the same changes to 1.9. versioned docs.

Will add something how to use CodeFromRemote to documentation docs....

@aeneasr
Copy link
Member

aeneasr commented Feb 2, 2021

Nice! Have you tested if this is doing what it should locally? :)

@vinckr
Copy link
Member Author

vinckr commented Feb 2, 2021

Yes, works locally!

@aeneasr aeneasr merged commit f20f645 into ory:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants