Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed basic examples for the golang SDK #2399

Merged
merged 2 commits into from
Mar 12, 2021
Merged

fixed basic examples for the golang SDK #2399

merged 2 commits into from
Mar 12, 2021

Conversation

cdreier
Copy link
Contributor

@cdreier cdreier commented Mar 10, 2021

the examples were a bit confusing, because the hydra-client was named admin - which conflicts with the correct import for the admin.NewCreateOAuth2ClientParams call.

i had to battle a bit around, and tried to rename a few variables and added correct imports, so the examples should just work when copy & pasting

to prevent confusion about the admin as hydra-client and the admin-import for the request creation
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2021

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr closed this Mar 11, 2021
@aeneasr
Copy link
Member

aeneasr commented Mar 11, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@aeneasr aeneasr reopened this Mar 11, 2021
@aeneasr
Copy link
Member

aeneasr commented Mar 11, 2021

(sorry, the close me clicking enter too soon)

@cdreier
Copy link
Contributor Author

cdreier commented Mar 11, 2021

thank you for clarification :)
i think now all changes are in both locations

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 6806865 into ory:master Mar 12, 2021
@cdreier cdreier deleted the patch-1 branch March 12, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants