Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update client filter to client_name #2706

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

pike1212
Copy link
Contributor

@pike1212 pike1212 commented Sep 1, 2021

Related issue(s)

#2691

Checklist

@aeneasr
Copy link
Member

aeneasr commented Sep 1, 2021

Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:

$ make format
$ git commit -a -m "styles: format code"
$ git push

Thank you!

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #2706 (f97070f) into master (336afa0) will increase coverage by 0.13%.
The diff coverage is 69.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2706      +/-   ##
==========================================
+ Coverage   52.68%   52.82%   +0.13%     
==========================================
  Files         234      235       +1     
  Lines       14040    14113      +73     
==========================================
+ Hits         7397     7455      +58     
- Misses       6016     6028      +12     
- Partials      627      630       +3     
Impacted Files Coverage Δ
client/handler.go 61.46% <ø> (ø)
oauth2/hook.go 63.93% <63.93%> (ø)
driver/config/provider.go 88.99% <100.00%> (+0.10%) ⬆️
driver/registry_base.go 89.28% <100.00%> (+0.21%) ⬆️
oauth2/handler.go 68.19% <100.00%> (+1.18%) ⬆️
persistence/sql/persister_oauth2.go 83.66% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7dcd1...f97070f. Read the comment docs.

@aeneasr aeneasr merged commit dee4fa2 into ory:master Sep 1, 2021
@aeneasr
Copy link
Member

aeneasr commented Sep 1, 2021

Awesome, thank you!

tnvmadhav added a commit to tnvmadhav/hydra that referenced this pull request Sep 15, 2021
This commit renders the docs to be in parity with an earlier change [1]

Reference(s):
[1] ory#2706
aeneasr pushed a commit that referenced this pull request Sep 15, 2021
This commit renders the docs to be in parity with an earlier change [1]

Reference(s):
[1] #2706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants