Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix hydra_client pk change mysql down migration #2791

Merged

Conversation

grantzvolsky
Copy link
Contributor

Related issue(s)

#2790
@aeneasr

Checklist

  • I have read the contributing guidelines.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • [] I have added tests that prove my fix is effective or that my feature
    works.
  • [n/a] I have added or changed the documentation.

Further Comments

I tested the change manually by writing the output of show create table hydra_client; before the up migration (a), after the up migration (b), and after the down migration (c), and making sure that a == c. We might want to add a test that does this automatically for all down migrations, or at least a convenience script that runs this procedure for a given migration.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v2.x@09ac91b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v2.x    #2791   +/-   ##
=======================================
  Coverage        ?   52.85%           
=======================================
  Files           ?      236           
  Lines           ?    14185           
  Branches        ?        0           
=======================================
  Hits            ?     7498           
  Misses          ?     6054           
  Partials        ?      633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ac91b...4c9bce5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants