Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link OIDC Certification image #3124

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix link OIDC Certification image #3124

merged 1 commit into from
May 24, 2022

Conversation

raman-nbg
Copy link
Contributor

@raman-nbg raman-nbg commented May 23, 2022

Related issue(s)

none

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

none

@raman-nbg raman-nbg requested a review from aeneasr as a code owner May 23, 2022 21:42
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@raman-nbg raman-nbg marked this pull request as draft May 23, 2022 21:48
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #3124 (066e0cb) into master (9bc59be) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3124      +/-   ##
==========================================
+ Coverage   79.35%   79.40%   +0.04%     
==========================================
  Files         112      112              
  Lines        7885     7879       -6     
==========================================
- Hits         6257     6256       -1     
+ Misses       1224     1221       -3     
+ Partials      404      402       -2     
Impacted Files Coverage Δ
cmd/clients.go 100.00% <0.00%> (ø)
persistence/sql/persister_oauth2.go 81.85% <0.00%> (+0.84%) ⬆️
cmd/cli/handler_helper.go 59.70% <0.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc59be...066e0cb. Read the comment docs.

@aeneasr aeneasr marked this pull request as ready for review May 24, 2022 08:46
@aeneasr aeneasr merged commit 17b517f into ory:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants