Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swagger for dynamic client registration #3141

Merged
merged 1 commit into from
Jun 8, 2022
Merged

fix: swagger for dynamic client registration #3141

merged 1 commit into from
Jun 8, 2022

Conversation

daniel-eichinger-bl
Copy link
Contributor

@daniel-eichinger-bl daniel-eichinger-bl commented Jun 8, 2022

Fix swagger documentation of the OAuth2 / OpenID Dynamic Client registration.
The endpoint was specified at /connect/register, but Ory Hydra exposes it at /oauth2/register.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Once this PR is merged, the documentation should also be updated: Ory Hydra docs
Will sign the CLA once clarified with my superior.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3141 (d9f14c8) into master (a383b5a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3141   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         112      112           
  Lines        7967     7967           
=======================================
  Hits         6336     6336           
  Misses       1225     1225           
  Partials      406      406           
Impacted Files Coverage Δ
client/handler.go 79.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7925597...d9f14c8. Read the comment docs.

@aeneasr
Copy link
Member

aeneasr commented Jun 8, 2022

Thank you!

@aeneasr aeneasr merged commit 9902ec7 into ory:master Jun 8, 2022
@daniel-eichinger-bl daniel-eichinger-bl deleted the fix/dynamic-client-registration-swagger branch June 8, 2022 08:37
@vinckr
Copy link
Member

vinckr commented Jun 8, 2022

Hello @daniel-eichinger-bl
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants