Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport migration fix to migration source #3267

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

grantzvolsky
Copy link
Contributor

@aarmam This adds your migration fix to the source that is used to generate the migrations[1].

[1]: make persistence/sql/migrations

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #3267 (f25fc4b) into master (15cdb88) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f25fc4b differs from pull request most recent head a180c26. Consider uploading reports for the commit a180c26 to get more accurate results

@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
- Coverage   76.80%   76.80%   -0.01%     
==========================================
  Files         123      123              
  Lines        8847     8845       -2     
==========================================
- Hits         6795     6793       -2     
  Misses       1627     1627              
  Partials      425      425              
Impacted Files Coverage Δ
fositex/config.go 85.71% <0.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr force-pushed the chore/backport-migration-fix branch from f25fc4b to a180c26 Compare October 4, 2022 06:31
@aeneasr aeneasr merged commit 3ba28f2 into master Oct 4, 2022
@aeneasr aeneasr deleted the chore/backport-migration-fix branch October 4, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants