Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidate tokens with inconsistent state #3385

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: invalidate tokens with inconsistent state #3385

merged 1 commit into from
Dec 7, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 7, 2022

This patch includes SQL migrations targeting environments which have not yet migrated to Ory Hydra 2.0. It removes inconsistent records which resolves issues during the migrations process. Please be aware that some users might be affected by this change. They might need to re-authorize certain apps. However, most active records should not be affected by this.

Installations already on Ory Hydra 2.0 will not be affected by this change.

Closes #3346

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This patch includes SQL migrations targeting environments which have not yet migrated to Ory Hydra 2.0. It removes inconsistent records which resolves issues during the migrations process. Please be aware that some users might be affected by this change. They might need to re-authorize certain apps. However, most active records should not be affected by this.

Installations already on Ory Hydra 2.0 will not be affected by this change.

Closes #3346
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3385 (cddf8ef) into master (d275ad6) will decrease coverage by 0.22%.
The diff coverage is 47.69%.

@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   76.95%   76.72%   -0.23%     
==========================================
  Files         123      123              
  Lines        9044     9076      +32     
==========================================
+ Hits         6960     6964       +4     
- Misses       1655     1669      +14     
- Partials      429      443      +14     
Impacted Files Coverage Δ
consent/strategy_default.go 69.59% <41.37%> (-1.34%) ⬇️
jwk/aead.go 56.52% <42.85%> (-8.19%) ⬇️
driver/config/provider_fosite.go 82.35% <50.00%> (-7.90%) ⬇️
driver/config/provider.go 82.55% <66.66%> (-0.58%) ⬇️
driver/registry_base.go 85.93% <66.66%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 542ea77 into master Dec 7, 2022
@aeneasr aeneasr deleted the fix-3346 branch December 7, 2022 13:10
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
This patch includes SQL migrations targeting environments which have not yet migrated to Ory Hydra 2.0. It removes inconsistent records which resolves issues during the migrations process. Please be aware that some users might be affected by this change. They might need to re-authorize certain apps. However, most active records should not be affected by this.

Installations already on Ory Hydra 2.0 will not be affected by this change.

Closes ory#3346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FK constraint hydra_oauth2_access_challenge_id_fk violation
1 participant