Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded dependency #3494

Merged
merged 1 commit into from Apr 18, 2023
Merged

chore: remove unneeded dependency #3494

merged 1 commit into from Apr 18, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 18, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #3494 (4644abe) into master (1b1899e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 4644abe differs from pull request most recent head 7d59b86. Consider uploading reports for the commit 7d59b86 to get more accurate results

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   76.85%   76.87%   +0.02%     
==========================================
  Files         124      124              
  Lines        9175     9175              
==========================================
+ Hits         7051     7053       +2     
+ Misses       1674     1673       -1     
+ Partials      450      449       -1     
Impacted Files Coverage Δ
oauth2/handler.go 66.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit cf20054 into master Apr 18, 2023
31 checks passed
@aeneasr aeneasr deleted the remove-crypto-dep branch April 18, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant