Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace fosite rewrite #3564

Merged
merged 1 commit into from
Jul 6, 2023
Merged

chore: replace fosite rewrite #3564

merged 1 commit into from
Jul 6, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 6, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3564 (a3a6951) into master (5bd9002) will decrease coverage by 0.09%.
The diff coverage is 9.09%.

❗ Current head a3a6951 differs from pull request most recent head 6945951. Consider uploading reports for the commit 6945951 to get more accurate results

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
- Coverage   76.68%   76.59%   -0.09%     
==========================================
  Files         129      129              
  Lines        9632     9639       +7     
==========================================
- Hits         7386     7383       -3     
- Misses       1748     1758      +10     
  Partials      498      498              
Impacted Files Coverage Δ
cmd/cmd_perform_authorization_code.go 13.55% <9.09%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 3914585 into master Jul 6, 2023
30 checks passed
@aeneasr aeneasr deleted the fix-fosite-dep branch July 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant