Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing index for jwk table #3691

Merged
merged 1 commit into from Jan 5, 2024
Merged

feat: add missing index for jwk table #3691

merged 1 commit into from Jan 5, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 4, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from hperl as a code owner January 4, 2024 17:19
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e94929) 76.11% compared to head (d7859f2) 75.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage   76.11%   75.96%   -0.15%     
==========================================
  Files         134      134              
  Lines       11764    10065    -1699     
==========================================
- Hits         8954     7646    -1308     
+ Misses       2238     1906     -332     
+ Partials      572      513      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 39ee5e1 into master Jan 5, 2024
31 of 32 checks passed
@aeneasr aeneasr deleted the nid-index branch January 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants