Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0: Towards production friendliness #445

Merged
merged 57 commits into from May 7, 2017
Merged

0.8.0: Towards production friendliness #445

merged 57 commits into from May 7, 2017

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 2, 2017

This PR tackles various things.

Breaking Changes

  • FindPoliciesForSubject was removed -> /policies no longer supports subject query parameter and instead offers pagination (offset (default 0), limit (default 500)) and is able to fetch all policies
  • RethinkDB + Redis removed
  • Upgrade ladon 0.5.0 -> 0.6.0 - requires database changes
  • Go 1.8 required
  • Move to ory namespace
  • Log format is now JSON
  • Policy for listing policies is now action=list, no longer action=find

Changes

  • Move to ory/herodot
  • Migrations need to be done by hand now
  • Moved everything to one logger instance
  • sql connections managable through DSN, introduced max_conns, max_idle_conns and max_conn_lifetime
  • Introduce LOG_FORMAT which supports json and none (text) for now.
  • swagger
  • creating a JWK previously required keys alg and id. id got renamed to kid now.
  • explain offline scope somewhere

To be done before merge

  • Code review
  • Test docker compose example extensively
  • Apply migrations to an existing hydra database
  • Test if policies work as expected in create scenarios

@aeneasr
Copy link
Member Author

aeneasr commented May 5, 2017

Ok, tests are now passing locally and all changes I wanted to address are now in. I'll give myself one or two days away from this issue and then review it and look for things that don't seem right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants