Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "request" dependency due to security vulnerability? CVE-2023-28155 #51

Closed
justin-wilxite opened this issue Mar 26, 2023 · 6 comments

Comments

@justin-wilxite
Copy link

The dependency "request" has a security vulnerability (reported by npm audit):

GHSA-p8p7-x288-28g6

The "request" library itself is deprecated:

request/request#3142

There is a PR on the project to fix the vulnerability, but it looks like it will not be merged:

request/request#3444

@Eskotus
Copy link

Eskotus commented Jun 29, 2023

Looks like it's not even used in the repository. Was it just forgotten in the deps?

@dan-j
Copy link
Contributor

dan-j commented Mar 26, 2024

Looks like this was addressed here: #60

Just needs a release cutting from main. Is there a plan to do this soon?

@aeneasr
Copy link
Member

aeneasr commented Mar 26, 2024

Thank you for letting us know - release is triggerd! Closing issue

@aeneasr aeneasr closed this as completed Mar 26, 2024
@aeneasr
Copy link
Member

aeneasr commented Mar 26, 2024

Looks like tests are failing: https://github.com/ory/integrations/actions/runs/8434909650/job/23099169259

Would appreciate help fixing the issues!

@dan-j
Copy link
Contributor

dan-j commented Mar 26, 2024

Tests pass locally on node 21, GitHub Actions are on 17.. do you want to upgrade, or fix the test on 17?

@dan-j
Copy link
Contributor

dan-j commented Mar 26, 2024

The version of next used on main requires >=18.17.0, if that helps answer your question? I've confirmed that tests pass on v18.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants