Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update packages & replace request dependency #60

Merged
merged 9 commits into from
Mar 13, 2024
Merged

fix: update packages & replace request dependency #60

merged 9 commits into from
Mar 13, 2024

Conversation

t1nky
Copy link
Contributor

@t1nky t1nky commented Feb 28, 2024

Updated dependencies
Removed the usage of request in next-edge
Added support for Next.js App Router
Overall refactor: separate common functions and consts

@t1nky
overall refactor
bdd8ffe 
add app router support
bump deps
fix tests
@t1nky
refactor
9b0c26b 
separate common functions and consts
refactor tests
@t1nky
refactor
341f6df 
removed tostring call for url in fetch
build url in next-edge
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

jonas-jonas
jonas-jonas approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is great.

I fixed the failing type import for you.

@jonas-jonas jonas-jonas requested a review from aeneasr March 5, 2024 09:23
@jonas-jonas
Copy link
Contributor

@t1nky Ah, just saw, could you sign the CLA? Otherwise, we can't merge this PR.

@jonas-jonas jonas-jonas changed the title App router support + Overall refactor fix: update pacakges & replace request dependency Mar 5, 2024
@jonas-jonas jonas-jonas changed the title fix: update pacakges & replace request dependency fix: update packages & replace request dependency Mar 5, 2024
@t1nky
Copy link
Contributor Author

t1nky commented Mar 13, 2024

@t1nky Ah, just saw, could you sign the CLA? Otherwise, we can't merge this PR.

Done, apologize for the delay

@aeneasr aeneasr merged commit 31e745b into ory:main Mar 13, 2024
3 checks passed
@dan-j dan-j mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-jonas jonas-jonas jonas-jonas approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t1nky @CLAassistant @jonas-jonas @aeneasr