Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow kratos to preload secret #370

Merged
merged 1 commit into from Nov 22, 2021

Conversation

Demonsthere
Copy link
Collaborator

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@Demonsthere
Copy link
Collaborator Author

@christian-roggia this should be an easy fix, allowing the user to preload the secret.
The secret has 2 required fields: dsn and smtpConnectionURI, as secretsDefault and secretsCookie are not required to be set in order to start kratos.

@Demonsthere Demonsthere merged commit 3e1e9a8 into ory:master Nov 22, 2021
@Demonsthere Demonsthere deleted the fix/kratos-preload-secret branch November 22, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-deployed kubernetes secrets will result in a broken kratos configuration
1 participant