Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of serviceAccountName on Kratos Courier - Fixes #434 #435

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Addition of serviceAccountName on Kratos Courier - Fixes #434 #435

merged 1 commit into from
Apr 25, 2022

Conversation

adamstrawson
Copy link
Contributor

@adamstrawson adamstrawson commented Apr 22, 2022

Related Issue or Design Document

The Kratos Courier stateful set doesn't include the ServiceAccountName, whereas is exists only on the Kratos deployment. Fixes #434

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, definitely it should be there :)

@Demonsthere Demonsthere merged commit d2d1650 into ory:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kratos Courier Stateful set doesn't include the ServiceAccountName
2 participants