fix: deployment template smtp secret ref

[iutx]

Related Issue or Design Document

Checklist

• I have read the contributing guidelines
  and signed the CLA.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got green light (please contact
  security@ory.sh) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added necessary documentation within the code base (if
  appropriate).

Further comments

[CLAassistant]

All committers have signed the CLA.

[Demonsthere]

Good catch, thanks! 😃

[dan2kx]

is this change needed? it means when doing an upgrade it will fail to add that secret ref and the pod will fail, unless a placeholder is used? Which happened to me...

[Demonsthere]

@dan2kx I'm a bit confused by your comments, by adding the guard we should not enforce the env if it is not set in the config. Before that change the env was always required

[dan2kx]

The secrets are created when the helm chart is first deployed and not on upgrade, so I would suggest this be moved to the secret chart if necessary?

since this change, when using this chart to upgrade, I have to add a fake secret to the values file for the container to use the secret that is already in the configured in kubernetes