Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed / from helm notes because kratos cli cannot handle the / #518

Merged
merged 1 commit into from Sep 27, 2022
Merged

chore: removed / from helm notes because kratos cli cannot handle the / #518

merged 1 commit into from Sep 27, 2022

Conversation

tikr7
Copy link
Contributor

@tikr7 tikr7 commented Sep 27, 2022

After installing kratos with helm, the notes say:

export KRATOS_PUBLIC_URL=http://127.0.0.1:80/
export KRATOS_ADMIN_URL=http://127.0.0.1:80/

The kratos cli cannot handle the last / (at least version v0.10.1, v0.10.0 and v0.9.0-alpha.3):

kratos ls identities 100 1
2022/09/27 08:57:43 [DEBUG] GET http://127.0.0.1:8081//admin/identities?page=100&per_page=1

(See //)

Just with:

export KRATOS_PUBLIC_URL=http://127.0.0.1:80
export KRATOS_ADMIN_URL=http://127.0.0.1:80

it works as expected. So I opened this PR to avoid the same issue for others.
Would be happy about a merge =)

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

@tikr7 tikr7 changed the title removed / from helm notes because kratos cli cannot handle the / chore: removed / from helm notes because kratos cli cannot handle the / Sep 27, 2022
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Good catch with the trailing slashes :) Tanks for the PR!

@Demonsthere Demonsthere merged commit 6a22a34 into ory:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants